Skip to content
Jump to bottom

Rename sg_ports.tf and clean up duplicate rules #42

Merged
merged 2 commits into from
Apr 17, 2025
Merged

Rename sg_ports.tf and clean up duplicate rules #42

merged 2 commits into from
Apr 17, 2025
+24 −57

Conversation

yang0352
Copy link
Contributor

  • Rename sg_ports.tf to additional_sg_rules.tf
  • Clean up duplicate rules
  • Add a comment

nangu001
nangu001 approved these changes Apr 16, 2025
View reviewed changes
Copy link
Collaborator

@nangu001 nangu001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@morga471 morga471 changed the base branch from main to mcmCluster April 17, 2025 00:00
morga471
morga471 approved these changes Apr 17, 2025
View reviewed changes
Copy link
Contributor

@morga471 morga471 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@morga471 morga471 merged commit e6db8f2 into mcmCluster Apr 17, 2025
1 check passed
@morga471 morga471 deleted the improve/node-security-group branch April 17, 2025 00:00
morga471 added a commit that referenced this pull request Apr 18, 2025
@yang0352 @morga471
Rename sg_ports.tf and clean up duplicate rules (#42)
159a98a 
- Rename sg_ports.tf to additional_sg_rules.tf
- Clean up duplicate rules
- Add a comment

---------

Co-authored-by: Matthew Creal Morgan <matthew.c.morgan@census.gov>
Sign in to join this conversation on GitHub.
Reviewers

@morga471 morga471 morga471 approved these changes

@nangu001 nangu001 nangu001 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@yang0352 @morga471 @nangu001